[webkit-reviews] review granted: [Bug 101821] Track subframe count to avoid traversing the tree when there's no subframes : [Attachment 177693] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 101821: Track subframe count to avoid traversing the tree when there's no
subframes
https://bugs.webkit.org/show_bug.cgi?id=101821

Attachment 177693: Patch
https://bugs.webkit.org/attachment.cgi?id=177693&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177693&action=review


> Source/WebCore/html/HTMLFrameOwnerElement.cpp:69
> +    // FIXME: This causes an unload event in the subframe which could
execute
> +    // script that would reach into up into this document.

What's the fix here? Not clear to me what the problem is from this description.


> LayoutTests/fast/frames/parser-append-subframe-count.html:15
> +    This test should not cause crash or asserts decrementing the connected

nit: s/crash/crashes/