[webkit-reviews] review denied: [Bug 102654] Zero size gradient should paint nothing on canvas : [Attachment 177980] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rashmi Shyamasundar
<rashmi.s2 at samsung.com>'s request for review:
Bug 102654: Zero size gradient should paint nothing on canvas
https://bugs.webkit.org/show_bug.cgi?id=102654

Attachment 177980: Patch
https://bugs.webkit.org/attachment.cgi?id=177980&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177980&action=review


Given that we already have this check for fillRect and Opera and IE are
compatible with the spec, I think we should go ahead with this.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2249
> +    // If gradient size is zero, then paint nothing.
> +    Gradient* gradient = c->strokeGradient();
> +    if (gradient && gradient->isZeroSize())
> +	   return;
> +
> +    // If gradient size is zero, then paint nothing.
> +    gradient = c->fillGradient();
> +    if (gradient && gradient->isZeroSize())
> +	   return;

I am not sure about this part. Why shouldn't we fill, if just the stroke
gradient is bogus? (Same the other way around.)

> LayoutTests/canvas/philip/tests.js:195
> +
> +

remove these extra lines.