[webkit-reviews] review granted: [Bug 103539] seamless iframes don't inherit styles when srcdoc is used : [Attachment 181076] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 2 15:46:53 PST 2013
Antti Koivisto <koivisto at iki.fi> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 103539: seamless iframes don't inherit styles when srcdoc is used
https://bugs.webkit.org/show_bug.cgi?id=103539
Attachment 181076: Patch
https://bugs.webkit.org/attachment.cgi?id=181076&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=181076&action=review
> Source/WebCore/dom/Document.cpp:2259
> + // Documents rendered seamlessly should start out requiring a style
> + // recalculation in order to ensure they inherit all the relevant data
> + // from their parent.
The comment is wrong. We don't need style recalc, we need stylesheet collection
update. The style recalc is just a side effect.
More information about the webkit-reviews
mailing list