[webkit-reviews] review denied: [Bug 105367] [chromium] Creation of dedicated workers (isolates) leaks reference to HTMLDocument : [Attachment 180978] Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied Kenneth Russell
<kbr at google.com>'s request for review:
Bug 105367: [chromium] Creation of dedicated workers (isolates) leaks reference
to HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=105367

Attachment 180978: Patch
https://bugs.webkit.org/attachment.cgi?id=180978&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180978&action=review


r- due to "void*" comment.

> Source/WebCore/workers/WorkerLoaderProxy.h:62
> +	   virtual void* toWebWorkerBase() = 0;

Lets try to forward-declare the return type here.

In general, it's unfortunate to introduce the 'embedder context' into
WorkerLoaderProxy. Is there a better solution?