[webkit-reviews] review granted: [Bug 105473] Implement :future pseudo class for the WebVTT ::cue pseudo element : [Attachment 180558] Proposed fix 0.4

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Dima Gorbik <dgorbik at apple.com>'s
request for review:
Bug 105473: Implement :future pseudo class for the WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=105473

Attachment 180558: Proposed fix 0.4
https://bugs.webkit.org/attachment.cgi?id=180558&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=180558&action=review


Looks good, r=me. Please fix the style issues.

> Source/WebCore/css/StyleResolver.cpp:1243
> +    if (element->isWebVTTNode() !=  m_element->isWebVTTNode())

extra space after !=

> Source/WebCore/dom/NodeRareData.h:276
>	   , m_childrenAffectedByBackwardPositionalRules(false)
> +#if ENABLE(VIDEO_TRACK)
> +    , m_WebVTTNodeType(TextTrack::WebVTTNodeTypeNone)
> +#endif

intendation.