[webkit-reviews] review denied: [Bug 105940] AX: Chromium needs platform localized strings for media controls. : [Attachment 181057] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 2 14:09:36 PST 2013


Tony Chang <tony at chromium.org> has denied David Tseng <dtseng at google.com>'s
request for review:
Bug 105940: AX: Chromium needs platform localized strings for media controls.
https://bugs.webkit.org/show_bug.cgi?id=105940

Attachment 181057: Patch
https://bugs.webkit.org/attachment.cgi?id=181057&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181057&action=review


Seems fine, just fix the ChangeLog.

> Source/Platform/ChangeLog:1
> +2013-01-02  My Name	<my at email>

Please put your name and email here. I think you can set user.name and
user.email in git to have this automatically filled in.

> Source/WebKit/chromium/ChangeLog:1
> +2013-01-02  My Name	<my at email>

Please put your name and email here.

> Source/WebKit/chromium/ChangeLog:18
> +2013-01-02  My Name	<my at email>
> +
> +	   Need a short description (OOPS!).
> +	   Need the bug URL (OOPS!).
> +
> +	   Reviewed by NOBODY (OOPS!).

Looks like this got duplicated.


More information about the webkit-reviews mailing list