[webkit-reviews] review denied: [Bug 105728] [BlackBerry] Update BB10 media render theme. : [Attachment 181059] Patch

[bugzilla-daemon at webkit.org]

Yong Li <yoli at rim.com> has denied Tiancheng Jiang <tijiang at rim.com>'s request
for review:
Bug 105728: [BlackBerry] Update BB10 media render theme.
https://bugs.webkit.org/show_bug.cgi?id=105728

Attachment 181059: Patch
https://bugs.webkit.org/attachment.cgi?id=181059&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=181059&action=review


> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1094
> +    static Image* mediaSliderThumb;
> +    if (!isEnabled(object))
> +	   mediaSliderThumb =
Image::loadPlatformResource("core_slider_handle_disabled").leakRef();
> +    else {
> +	   if (isPressed(object) || isHovered(object) || isFocused(object))
> +	       mediaSliderThumb =
Image::loadPlatformResource("core_slider_handle_pressed").leakRef();
> +	   else
> +	       mediaSliderThumb =
Image::loadPlatformResource("core_media_handle").leakRef();
> +    }

will this leak an image every time? I would use 3 static Image* objects that
are initialized upon first time, and then reused.