[webkit-reviews] review denied: [Bug 105458] [chromium] Pass the PageOverlay's layer to WebLayerTreeView : [Attachment 180263] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied egraether at chromium.org's
request for review:
Bug 105458: [chromium] Pass the PageOverlay's layer to WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=105458

Attachment 180263: Patch
https://bugs.webkit.org/attachment.cgi?id=180263&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180263&action=review


> Source/Platform/ChangeLog:9
> +	   WebLayerTreeView. Thereon this layer can be identified in the layer
tree.

typo "Thereon". This doesn't explain why the page overlay layer needs to be
treated specially

> Source/Platform/chromium/public/WebLayerTreeView.h:196
> +    // Passes a reference of the PageOverlay's layer to exclude it from
continuous painting.
> +    // That way it doesn't affect the totalPaintTime measurement.
> +    virtual void setPageOverlayLayer(const WebLayer*) { }

Is this really necessary?  For general performance measurements there won't be
a page overlay layer at all, but if there is some case where the page overlay
is typically visible then it's something the user sees and should be counted
with all other content.