[webkit-reviews] review granted: [Bug 104740] Generate internal.settings from Settings.in : [Attachment 181055] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 2 13:43:42 PST 2013
Adam Barth <abarth at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 104740: Generate internal.settings from Settings.in
https://bugs.webkit.org/show_bug.cgi?id=104740
Attachment 181055: Patch
https://bugs.webkit.org/attachment.cgi?id=181055&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181055&action=review
> Source/WebCore/testing/InternalSettings.cpp:152
> +class InternalSettingsWrapper : public Supplement<Page> {
I'd add a comment explaining why we're not using RefCountedSupplement
More information about the webkit-reviews
mailing list