[webkit-reviews] review granted: [Bug 105619] Remove old-run-webkit-tests support from webkitpy : [Attachment 181044] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 105619: Remove old-run-webkit-tests support from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=105619

Attachment 181044: Patch
https://bugs.webkit.org/attachment.cgi?id=181044&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181044&action=review


I suspect there is more than this.  :)	But this is a start.

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:88
>	   return LayoutTestResults.results_from_string(results_file)

This could call results_from_json directly now, I think.

> Tools/Scripts/webkitpy/common/net/layouttestresults.py:63
>      # FIXME: run-webkit-tests should store the --exit-after-N-failures value


This seems like this would be trivial for one of us to fix.  I'm kinda
surprised this is still here. :(

> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:-182
> -	       # This differs from ORWT because it does not include WebProcess
crashes.

I would leave this in?	I'm not sure if WebKit2 folks care about this or not.