[webkit-reviews] review granted: [Bug 105897] [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing : [Attachment 180990] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 105897: [WK2] plugins/clicking-missing-plugin-fires-delegate.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=105897

Attachment 180990: Patch
https://bugs.webkit.org/attachment.cgi?id=180990&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180990&action=review


> Tools/WebKitTestRunner/TestController.cpp:1112
> +void TestController::unavailablePluginButtonClicked(WKPageRef,
WKPluginUnavailabilityReason, WKStringRef /*mimeType*/, WKStringRef /*url*/,
WKStringRef /*pluginsPageURL*/, const void*)

I would leave arguments names completely, not just comment them out. They are
not even present in header.