[webkit-reviews] review denied: [Bug 105786] [TexMap] Use a premuliplied color in TextureMapperGL. : [Attachment 180849] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 105786: [TexMap] Use a premuliplied color in TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=105786

Attachment 180849: Patch
https://bugs.webkit.org/attachment.cgi?id=180849&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180849&action=review


> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:435
> +    Color(premultipliedARGBFromColor(color)).getRGBA(r, g, b, a);

Look at TextureMapperLayer, we do premultiply the color, though maybe not in
the correct way. if this patch tries to correct this it has to finish the job
;)