[webkit-reviews] review granted: [Bug 111035] Reduce amount of rebuilding when touching networking headers : [Attachment 190886] patch for review

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 111035: Reduce amount of rebuilding when touching networking headers
https://bugs.webkit.org/show_bug.cgi?id=111035

Attachment 190886: patch for review
https://bugs.webkit.org/attachment.cgi?id=190886&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190886&action=review


LGTM.  I'm curious to read any tips/tricks you learned about how to go about
such a compile-time reduction as you did.  Did you just keep touching a header
and see how many files it built?

> Source/WebCore/page/Frame.h:219
> +	   mutable OwnPtr<FrameLoader> m_loader;

I wonder if this still needs to be mutable.