[webkit-reviews] review denied: [Bug 111116] Disable window occlusion detection for WebKitTestRunner Web View on Mac : [Attachment 190862] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 18:59:13 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Kiran Muppala
<cmuppala at apple.com>'s request for review:
Bug 111116: Disable window occlusion detection for WebKitTestRunner Web View on
Mac
https://bugs.webkit.org/show_bug.cgi?id=111116

Attachment 190862: Patch
https://bugs.webkit.org/attachment.cgi?id=190862&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190862&action=review


> Tools/ChangeLog:11
> +	   Window occlusion notifications on Mac cause the WebKitTestRunner's
> +	   Web View to be treated as invisible and this automatically enables
> +	   JavaScript timer throttling, causing some layout tests exercising
> +	   JavaScript timers to fail.  Hence, disable window occlusion
detection.

This doesn't seem to match the patch (yes, I know it's a follow-up but should
not be copied from the other bug).


More information about the webkit-reviews mailing list