[webkit-reviews] review granted: [Bug 110779] WebKit API for enabling DOM logging for certain worlds : [Attachment 190861] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ankur Taly <ataly at google.com>'s
request for review:
Bug 110779: WebKit API for enabling DOM logging for certain worlds
https://bugs.webkit.org/show_bug.cgi?id=110779

Attachment 190861: Patch
https://bugs.webkit.org/attachment.cgi?id=190861&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190861&action=review


This looks good.  There's just one nit about the include.  You've probably left
the office for today, so I can try fixing that for you.

> Source/WebCore/bindings/v8/V8DOMActivityLogger.h:2
> + * Copyright (C) 2009 Google Inc. All rights reserved.

2009 -> 2013

> Source/WebKit/chromium/public/WebDOMActivityLogger.h:34
> +#include "../../../Platform/chromium/public/WebCanvas.h"

Why do we need this?  You should include WebCommon.h or something like that.

> Source/WebKit/chromium/src/WebDOMActivityLogger.cpp:53
> +private:

nit: We would normally put a blank line above this line.