[webkit-reviews] review granted: [Bug 111130] The threaded HTML parser shouldn't need to invalidate the speculation buffer on every document.write : [Attachment 190851] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 111130: The threaded HTML parser shouldn't need to invalidate the
speculation buffer on every document.write
https://bugs.webkit.org/show_bug.cgi?id=111130

Attachment 190851: Patch
https://bugs.webkit.org/attachment.cgi?id=190851&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190851&action=review


Looks amazing.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:337
> +    if (m_currentChunk->tokenizerState == HTMLTokenizer::DataState &&
m_tokenizer->state() == HTMLTokenizer::DataState &&
m_input.current().isEmpty()) {

I would split this off into a nicely named funtion. 
isSafeToContinueSpeculation()?