[webkit-reviews] review denied: [Bug 110496] WEBGL_compressed_texture_atc needs implementation : [Attachment 190805] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Brandon Jones
<bajones at chromium.org>'s request for review:
Bug 110496: WEBGL_compressed_texture_atc needs implementation
https://bugs.webkit.org/show_bug.cgi?id=110496

Attachment 190805: Patch
https://bugs.webkit.org/attachment.cgi?id=190805&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190805&action=review


The code looks OK but the patch needs to be rebaselined to pass the EWS. Also
there's a problem with the layout test.

> LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-atc.html:1
> +<!--

This isn't right -- the real test should go under resources/webgl_test_files/
and this should just be a wrapper. Please use the webgl/generate-webgl-tests.py
script to generate this (you'll need to ignore the other changes it makes to
your tree). Also, watch out for those leading non-ASCII characters -- not sure
where those are coming from.