[webkit-reviews] review granted: [Bug 111030] Merge more methods on PerfTest : [Attachment 190635] Cleanup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 28 12:51:02 PST 2013
Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 111030: Merge more methods on PerfTest
https://bugs.webkit.org/show_bug.cgi?id=111030
Attachment 190635: Cleanup
https://bugs.webkit.org/attachment.cgi?id=190635&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190635&action=review
>> Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:166
>> + self.assertIsNone(test._run_with_driver(None, None))
>
> [TestPerfTest.test_parse_output_with_failing_line] Instance of 'TestPerfTest'
has no 'assertIsNone' member [pylint/E1101] [5]
I think this are false positives having to do with our unittest2 shenanigans.
Mind filing a bug for that?
More information about the webkit-reviews
mailing list