[webkit-reviews] review denied: [Bug 110921] Web Inspector: allow referencing of nodes that have not been pushed to the front-end : [Attachment 190769] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 110921: Web Inspector: allow referencing of nodes that have not been pushed
to the front-end
https://bugs.webkit.org/show_bug.cgi?id=110921

Attachment 190769: Patch
https://bugs.webkit.org/attachment.cgi?id=190769&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190769&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:324
> +    if (m_nodeToBackendIdMap.contains(node)) {

This method will only call itself recursively in case of mapped nodes /
childrenRequested, etc. At the same time, your node might be in the removed
subtree.

There is a couple of solutions I see depending on what operation you want to be
fast:
1) in case backend map is not empty, traverse the entire subtree being removed
here
2) when backendId is being created, generate backendids for the entire path
from node to root. Then know for sure whether you need to traverse nodes here.