[webkit-reviews] review denied: [Bug 102775] Loader: Store WeakRef CachedResourceHandle in CachedResourceLoader : [Attachment 190715] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied pdeng6 <pan.deng at intel.com>'s request
for review:
Bug 102775: Loader: Store WeakRef CachedResourceHandle in CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=102775

Attachment 190715: Patch
https://bugs.webkit.org/attachment.cgi?id=190715&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190715&action=review


> Source/WTF/wtf/WeakPtr.h:118
> +    // It somewhat breaks the type system, however to allow transfer of
ownership
> +    // out of a const WeakPtrFactory is really a need.
> +    WeakPtrFactory<T>(const WeakPtrFactory<T>& factory) :
m_ref(factory.leakRef()) { }

I don't think we want to break the type system in this way.