[webkit-reviews] review denied: [Bug 110921] Web Inspector: allow referencing of nodes that have not been pushed to the front-end : [Attachment 190757] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 110921: Web Inspector: allow referencing of nodes that have not been pushed
to the front-end
https://bugs.webkit.org/show_bug.cgi?id=110921

Attachment 190757: Patch
https://bugs.webkit.org/attachment.cgi?id=190757&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190757&action=review


>> Source/WebCore/inspector/InspectorDOMAgent.cpp:1746
>> +	if (Node * node = m_backendIdToNode.get(backendNodeId)) {
> 
> Style: Node* node = ...

What if the node was deleted? You should clean up your binding upon node
deletion.