[webkit-reviews] review denied: [Bug 110918] Need API to control page underlay color : [Attachment 190668] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Conrad Shultz
<conrad_shultz at apple.com>'s request for review:
Bug 110918: Need API to control page underlay color
https://bugs.webkit.org/show_bug.cgi?id=110918

Attachment 190668: Patch
https://bugs.webkit.org/attachment.cgi?id=190668&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190668&action=review


> Source/WebCore/page/ChromeClient.h:190
> +    virtual Color underlayColor() const = 0;

I think this should not be pure virtual, and can return Color() so you don't
have to touch all the other clients.

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:620
> +    graphicsLayer->platformLayer().backgroundColor =
backgroundColor.isValid() ? nsColor(backgroundColor).CGColor :
cachedLinenBackgroundColor;

I think this should use cachedCGColor(backgroundColor, ColorSpaceDeviceRGB).