[webkit-reviews] review granted: [Bug 111089] Remove the quirk margin bits from RenderObject and put them back in RenderBlock : [Attachment 190752] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 10:34:14 PST 2013


mitz at webkit.org <mitz at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 111089: Remove the quirk margin bits from RenderObject and put them back in
RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=111089

Attachment 190752: Patch
https://bugs.webkit.org/attachment.cgi?id=190752&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190752&action=review


> Source/WebCore/rendering/RenderBlock.h:152
> +    bool childHasMarginBeforeQuirk(const RenderBox* child) const;
> +    bool childHasMarginAfterQuirk(const RenderBox* child) const;

Probably don’t need the name “child” here.


More information about the webkit-reviews mailing list