[webkit-reviews] review denied: [Bug 111064] Web Inspector: fix code-mirror experiment to work in debug mode : [Attachment 190693] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 111064: Web Inspector: fix code-mirror experiment to work in debug mode
https://bugs.webkit.org/show_bug.cgi?id=111064

Attachment 190693: Patch
https://bugs.webkit.org/attachment.cgi?id=190693&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190693&action=review


> Source/WebCore/WebCore.gypi:5208
> +	       'inspector/front-end/CodeMirrorTextEditor.js',

How come it is in two places at a time?

> Source/WebCore/WebCore.gypi:5466
> +	   'webinspector_codemirror_inline_files': [

We had no notion of inline files, just modules. Why making things complex?

> Source/WebCore/WebCore.gypi:5478
> +	   'webinspector_debug_standalone_files': [

This hurts modularity - this is about cm, not standalone?

> Source/WebKit/chromium/WebKit.gyp:856
> +				   ['include', '/cm/'],

I think we should either split all modules by folders or not do it at all.