[webkit-reviews] review granted: [Bug 110852] [WIP] [V8] Added V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetters. : [Attachment 190676] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 01:32:55 PST 2013


Kentaro Hara <haraken at chromium.org> has granted Koji Hara
<kojih at chromium.org>'s request for review:
Bug 110852: [WIP] [V8] Added V8CustomIndexedGetter to IDLs that correspond to
existing custom indexedPropertyGetters.
https://bugs.webkit.org/show_bug.cgi?id=110852

Attachment 190676: Patch
https://bugs.webkit.org/attachment.cgi?id=190676&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190676&action=review


Looks reasonable.

> Source/WebCore/ChangeLog:12
> +	   This is preparation for refactoring CodeGeneratorV8.pm

You might want to elaborate on why you are making this change so that others
can understand what we're doing.


More information about the webkit-reviews mailing list