[webkit-reviews] review granted: [Bug 110675] IndexedDB: IO error when checking schema should destroy LevelDB directory : [Attachment 190568] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 00:35:04 PST 2013


Adam Barth <abarth at webkit.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 110675: IndexedDB: IO error when checking schema should destroy LevelDB
directory
https://bugs.webkit.org/show_bug.cgi?id=110675

Attachment 190568: Patch
https://bugs.webkit.org/attachment.cgi?id=190568&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190568&action=review


I'm not sure about the GYP cargo culting, but the rest looks sane.

> Source/WebKit/chromium/ChangeLog:9
> +	   This was cargo-culted. The component build wouldn't run otherwise.

:)

> Source/WebKit/chromium/WebKit.gyp:646
> +				   'tests/IDBCleanupOnIOErrorTest.cpp',

ugg


More information about the webkit-reviews mailing list