[webkit-reviews] review granted: [Bug 111040] Add new webkit API to invoke a context menu. : [Attachment 190656] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 111040: Add new webkit API to invoke a context menu.
https://bugs.webkit.org/show_bug.cgi?id=111040

Attachment 190656: Patch
https://bugs.webkit.org/attachment.cgi?id=190656&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190656&action=review


> Source/WebKit/chromium/public/WebView.h:409
> +    virtual void showContextMenu() = 0;

Should we add a comment saying that this command is directed at the current
focus?

> Source/WebKit/chromium/src/WebViewImpl.cpp:3676
> +    if (!page() || !page()->focusController())

How can a page not have a focusController?  It looks like its created in the
constructor and never cleared.

> Source/WebKit/chromium/src/WebViewImpl.cpp:3682
> +    Frame* focusedFrame = page()->focusController()->focusedOrMainFrame();
> +    if (focusedFrame)

You can combine these two lines.

> Source/WebKit/chromium/src/WebViewImpl.h:306
> +    virtual void showContextMenu() OVERRIDE;

None of these other methods have OVERRIDE.  Perhaps we should skip it here too?