[webkit-reviews] review denied: [Bug 110939] Move markerTextForListItem from TestRunner to Internals : [Attachment 190627] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jason Anderssen
<janderssen at gmail.com>'s request for review:
Bug 110939: Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939

Attachment 190627: Patch
https://bugs.webkit.org/attachment.cgi?id=190627&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190627&action=review


Looks great. Some comments still:

> Source/WebCore/ChangeLog:10
> +	   as to make it more compatible with WK2

Missing period.

> Source/WebCore/testing/Internals.cpp:2013
> +String Internals::markerTextForListItem(Element* inputElement,
ExceptionCode& ec)

In this case, valid input does not necessarily have to be an inputElement.
The argument name should be simply "element".

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:-138
> -{
> -    return toCopiedAPI(toImpl(frameRef)->markerText(element));
> -}

Thanks to this, you are making WebFrame::markerText useless. You should also
clean that as part of the patch.

You can probably remove the include for RenderTreeAsText.h from WebFrame too.