[webkit-reviews] review granted: [Bug 109772] Move computedStyleIncludingVisitedInfo from TestRunner to Internals : [Attachment 190637] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 109772: Move computedStyleIncludingVisitedInfo from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109772

Attachment 190637: Patch
https://bugs.webkit.org/attachment.cgi?id=190637&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190637&action=review


r=me. This is great.

> Source/WebCore/testing/Internals.idl:37
> +    CSSStyleDeclaration computedStyleIncludingVisitedInfo(in Node node)
raises(DOMException);

The TestRunner version took an Element argument, not a Node.
I don't think that's really a problem though, computed styles can be created
from nodes, so it makes sense to support this in Internals.