[webkit-reviews] review granted: [Bug 109555] INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of hour field should respect min/max attributes : [Attachment 190473] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 27 21:14:54 PST 2013


Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Kunihiko
Sakamoto <ksakamoto at chromium.org>'s request for review:
Bug 109555: INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of hour field should
respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=109555

Attachment 190473: Patch 2
https://bugs.webkit.org/attachment.cgi?id=190473&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190473&action=review


Almost good.

> Source/WebCore/html/shadow/DateTimeEditElement.cpp:80
> +    int m_minDay, m_maxDay, m_minHour23, m_maxHour23;

nit: We usually declare one data member per one line.


More information about the webkit-reviews mailing list