[webkit-reviews] review granted: [Bug 110913] Mac: Incorrect rendering of <audio> controls : [Attachment 190586] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Christian Biesinger
<cbiesinger at chromium.org>'s request for review:
Bug 110913: Mac: Incorrect rendering of <audio> controls
https://bugs.webkit.org/show_bug.cgi?id=110913

Attachment 190586: Patch
https://bugs.webkit.org/attachment.cgi?id=190586&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190586&action=review


> Source/WebCore/ChangeLog:29
> +	   Override minPreferredLogicalWidth and maxPreferredLogicalWidth to
return 0 if we're collapsed.
> +	   Add a m_collapsed member to indicate if we are collapsed.

This text is out of date.

> Source/WebCore/rendering/RenderMediaControlElements.cpp:80
>	   setWidth(0);
> +	   m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = 0;

This looks better.