[webkit-reviews] review denied: [Bug 62367] Web Inspector: Make it obvious where command line functions come from : [Attachment 190543] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mike West
<mkwst at chromium.org>'s request for review:
Bug 62367: Web Inspector: Make it obvious where command line functions come
from
https://bugs.webkit.org/show_bug.cgi?id=62367

Attachment 190543: Patch
https://bugs.webkit.org/attachment.cgi?id=190543&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190543&action=review


> Source/WebCore/inspector/InjectedScriptSource.js:1123
> +    function customToStringMethod(arg) {

Please follow the style guide for function declaration.

> Source/WebCore/inspector/InjectedScriptSource.js:1124
> +	   return function () { return "function " + arg + "() { [WebInspector
Command-Line Method] }"; };

Please use "Command Line API" string. It is port agnostic and can be searched
for.