[webkit-reviews] review granted: [Bug 111003] REGRESSION (48533): Full-frame plugins stopped working (download instead of loading the plugin) : [Attachment 190575] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 111003: REGRESSION (48533): Full-frame plugins stopped working (download
instead of loading the plugin)
https://bugs.webkit.org/show_bug.cgi?id=111003

Attachment 190575: Patch
https://bugs.webkit.org/attachment.cgi?id=190575&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190575&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3794
> +    if (PluginData* pluginData = m_page->pluginData()) {
> +	   if (pluginData->supportsMimeType(MIMEType) &&
m_page->settings()->arePluginsEnabled())
> +	       return true;
> +    }

I think you want to check if plug-ins are enabled before calling pluginData,
since that can be a sync call out to the web process.