[webkit-reviews] review denied: [Bug 108294] Coordinated Graphics: CoordinatedGraphicsLayer makes CoordinatedGraphicsScene perform via CoordinatedGraphicsOperation. : [Attachment 190515] WIP. discussion for APIs for CoordinatedGraphicsState

[bugzilla-daemon at webkit.org]

Gwang Yoon Hwang <ryumiel at company100.net> has denied  review:
Bug 108294: Coordinated Graphics: CoordinatedGraphicsLayer makes
CoordinatedGraphicsScene perform via CoordinatedGraphicsOperation.
https://bugs.webkit.org/show_bug.cgi?id=108294

Attachment 190515: WIP. discussion for APIs for CoordinatedGraphicsState
https://bugs.webkit.org/attachment.cgi?id=190515&action=review

------- Additional Comments from Gwang Yoon Hwang <ryumiel at company100.net>
As we discussed in IRC, I made new patch for this issue.

The main focus of this patch is unifying coordinated graphic's messages into
CoordinatedGraphicsState.

Each CoordinatedGraphicsLayer has a CoordiantedGraphicsLayerState, and whenever
it needs sync, CoordinatedGraphicsLayer
commits to CoordinatedLayerTreeHost, which will store committed states from
layers.

And CoordinatedLayerTreeHost sends stored states from layers, and state changes
for global state using single command.
(current patch uses DidRenderFrame but it will be better to use
CommitCooridnatedGraphicsState)
We can add preprocessing steps for IPC in LayerTreeCoordiantedHost.
The requirement from https://bugs.webkit.org/show_bug.cgi?id=109579 can be
achieved using this.(#37)
(But I am not sure it is correct design decision)

To minimize IPC overhead, the size of encoded CoordinatedGraphicsLayerState is
variable.
(CoordinatedGraphicsArgumentCoder checks dirty bit of
CoordinatedGraphicsLayerState before encoding.) 

This patch is not working now, due to the bugs, but I think I need to share
status.


I'll post working/clean version ASAP.