[webkit-reviews] review granted: [Bug 110967] Add calendar header for new calendar picker : [Attachment 190490] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 110967: Add calendar header for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110967

Attachment 190490: Patch
https://bugs.webkit.org/attachment.cgi?id=190490&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190490&action=review


> Source/WebCore/Resources/pagepopups/calendarPicker.js:1925
> +/**
> + * @return {!boolean}
> + */
> +MonthPopupButton.prototype._shouldUseShortMonth = function(maxWidth) {

Need @param for maxWidth.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1974
> +CalendarNavigationButton.DefaultrepeatingClicksStartingThreshold = 600;
> +CalendarNavigationButton.DefaultRepeatingClicksInterval = 300;

Ideally, these values should be synchronized with
RenderTheme::initialAutoscrollTimerDelay and autoscrollTimerDelay.
You might want to change so later.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:2096
> +	  
this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().previous
(), true);
> +    else if (sender === this._nextMonthButton)
> +	  
this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().next(),
true);

boolean argument isn't good.