[webkit-reviews] review granted: [Bug 110949] HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can trigger ASSERT(m_speculations.isEmpty()) : [Attachment 190454] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 110949: HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can
trigger ASSERT(m_speculations.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=110949

Attachment 190454: Patch
https://bugs.webkit.org/attachment.cgi?id=190454&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190454&action=review


> Source/WebCore/html/parser/HTMLDocumentParser.cpp:311
> +    if (isWaitingForScripts() || !m_speculations.isEmpty()) {

I see.	So we've yielded all the way out to the event loop and are getting more
data from teh background parser.  I'm sure we hit this all the time in the wild
and may be a source of all sorts of bad behavior!