[webkit-reviews] review granted: [Bug 110867] XHR should fire 'abort' event when navigation interrupts a request. : [Attachment 190255] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 110867: XHR should fire 'abort' event when navigation interrupts a request.
https://bugs.webkit.org/show_bug.cgi?id=110867

Attachment 190255: Patch
https://bugs.webkit.org/attachment.cgi?id=190255&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190255&action=review


> LayoutTests/http/tests/xmlhttprequest/navigation-should-abort-expected.txt:2
> +This is just a minimal page that we navigate to as part of testing
back/forward.

This is not accurate. I suggest using a different page, that also says
something helpful when opened in a browser manually.

> LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html:7
> +	       testRunner.dumpBackForwardList();

I do not understand why dumping b/f list is helpful.

> LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html:11
> +	   req.open("GET", "/xmlhttprequest/resources/endlessxml.php");

I'd have used a relative path here.

> LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html:21
> +	       testRunner.queueLoad("/navigation/resources/otherpage.html");

Ditto (or maybe just a data: URL).