[webkit-reviews] review granted: [Bug 110925] PDFPlugin: PDF orientation isn't respected when printing or print-previewing : [Attachment 190400] print

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 110925: PDFPlugin: PDF orientation isn't respected when printing or
print-previewing
https://bugs.webkit.org/show_bug.cgi?id=110925

Attachment 190400: print
https://bugs.webkit.org/attachment.cgi?id=190400&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190400&action=review


> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:812
> +    NSInteger rotation = [pdfPage rotation];
> +    if (rotation == 90 || rotation == 270)
> +	   std::swap(cropBox.size.width, cropBox.size.height);

Please add a comment about why this is the right thing to do (which is because
we always autorotate). When we looked at this code previously, we both agreed
that it was wrong, so it's not at all obvious what's going on.