[webkit-reviews] review denied: [Bug 110779] WebKit API for enabling DOM logging for certain worlds : [Attachment 190408] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ankur Taly <ataly at google.com>'s
request for review:
Bug 110779: WebKit API for enabling DOM logging for certain worlds
https://bugs.webkit.org/show_bug.cgi?id=110779

Attachment 190408: Patch
https://bugs.webkit.org/attachment.cgi?id=190408&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190408&action=review


> Source/WebCore/bindings/v8/DOMWrapperWorld.cpp:234
> +    coverWrappingLogs().set(worldID, adoptPtr(log));

That usage is not correct.  This function should take a PassOwnPtr as an
argument.  Please call adoptPtr immediately after calling new.