[webkit-reviews] review granted: [Bug 110911] Refactor RenderSVGModelObject on top of RenderLayerModelObject : [Attachment 190365] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 110911: Refactor RenderSVGModelObject on top of RenderLayerModelObject
https://bugs.webkit.org/show_bug.cgi?id=110911

Attachment 190365: Patch
https://bugs.webkit.org/attachment.cgi?id=190365&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190365&action=review


Looks very promising. r=me with some text enhancement requests.

> Source/WebCore/ChangeLog:10
> +	   chain but does not enble any layer-related SVG features.

Please add a description why we do not allow the creation of layers. That we
need to verify that SVG transforms still work on elements that create layers.

> Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:113
> +    // FIXME: SVG layers not allowed yet.

Can you add a note that we do not allow it, since we do not know the influence
on transforms? I think this is the main problem. When we have tests that verify
that transforms work on creating a layer, we are fine. But we would need to
have at least one property creating a layer for sure. Not sure where we might
even benefit from. opacity?