[webkit-reviews] review denied: [Bug 110169] Encapsulate FloatingObject's constructor inside create : [Attachment 189024] Fixed builds

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 110169: Encapsulate FloatingObject's constructor inside create
https://bugs.webkit.org/show_bug.cgi?id=110169

Attachment 189024: Fixed builds
https://bugs.webkit.org/attachment.cgi?id=189024&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189024&action=review


> Source/WebCore/rendering/RenderBlock.cpp:7752
> +inline PassOwnPtr<RenderBlock::FloatingObjects>
RenderBlock::FloatingObjects::create(const RenderBlock* renderer, bool
horizontalWritingMode)
> +{
> +    return adoptPtr(new FloatingObjects(renderer, horizontalWritingMode));
> +}

For better encapsulation, remove horizontalWritingMode and do?:
    return adoptPtr(new FloatingObjects(renderer,
renderer->isHorizontalWritingMode()));

> Source/WebCore/rendering/RenderBlock.h:1178
>	   friend void RenderBlock::createFloatingObjects();

You should remove this.

> Source/WebCore/rendering/RenderBlock.h:1181
> +    friend OwnPtr<FloatingObjects>;
> +    friend PassOwnPtr<FloatingObjects>;

friend class xxx

For which scope was this needed?