[webkit-reviews] review denied: [Bug 110908] [GTK] Add libsecret package to jhbuild modules. : [Attachment 190352] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Tullio Lucena
<tullio.lucena at openbossa.org>'s request for review:
Bug 110908: [GTK] Add libsecret package to jhbuild modules.
https://bugs.webkit.org/show_bug.cgi?id=110908

Attachment 190352: Patch
https://bugs.webkit.org/attachment.cgi?id=190352&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190352&action=review


> Tools/gtk/jhbuild.modules:30
> +	 <dep package="libsecret"/>

Did you take a look at the bug ( https://bugs.webkit.org/show_bug.cgi?id=109195
) ? The purpose of the modules in jhbuild-optional is that they are optional.
The modules installed by default are ones in which having the exact version is
required for layout tests to pass. libsecret doesn't fall into this category
and making it non-optional means that everyone has to build it, even when they
don't need to.