[webkit-reviews] review granted: [Bug 110705] Not all properties apply to the '::cue' pseudo-element : [Attachment 190348] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 26 13:53:05 PST 2013


Antti Koivisto <koivisto at iki.fi> has granted Dima Gorbik <dgorbik at apple.com>'s
request for review:
Bug 110705: Not all properties apply to the '::cue' pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=110705

Attachment 190348: Patch
https://bugs.webkit.org/attachment.cgi?id=190348&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=190348&action=review


> Source/WebCore/html/track/TextTrackCue.cpp:745
> -    m_allDocumentNodes->setPseudo(allNodesShadowPseudoId());
> +    m_allDocumentNodes->setPseudo(cueShadowPseudoId());

m_allDocumentNodes could still use a less confusing name


More information about the webkit-reviews mailing list