[webkit-reviews] review granted: [Bug 110798] Factor SourceBuffer methods out of MediaSourcePrivate & WebMediaSource into SourceBufferPrivate & WebSourceBuffer respectively. : [Attachment 190128] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 110798: Factor SourceBuffer methods out of MediaSourcePrivate &
WebMediaSource into SourceBufferPrivate & WebSourceBuffer respectively.
https://bugs.webkit.org/show_bug.cgi?id=110798

Attachment 190128: Patch
https://bugs.webkit.org/attachment.cgi?id=190128&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190128&action=review


I don't feel 100% confident in reviewing this patch, but it seems correct. 
Should we get someone who knows the media code well to take a look as well?

> Source/WebKit/chromium/src/SourceBufferPrivateImpl.cpp:42
>
+SourceBufferPrivateImpl::SourceBufferPrivateImpl(WTF::PassOwnPtr<WebSourceBuff
er> sourceBuffer)

WTF::  <-- No need for this prefix.

> Source/WebKit/chromium/src/SourceBufferPrivateImpl.h:44
> +    explicit SourceBufferPrivateImpl(WTF::PassOwnPtr<WebSourceBuffer>);

ditto

> Source/WebKit/chromium/src/SourceBufferPrivateImpl.h:55
> +    WTF::OwnPtr<WebSourceBuffer> m_sourceBuffer;

ditto