[webkit-reviews] review granted: [Bug 110812] Implement channel up-mixing and down-mixing rules : [Attachment 190140] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 110812: Implement channel up-mixing and down-mixing rules
https://bugs.webkit.org/show_bug.cgi?id=110812

Attachment 190140: Patch
https://bugs.webkit.org/attachment.cgi?id=190140&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190140&action=review


Looks good. Thanks for the explanation offline about the algorithm and the
layout test. One comment.

> Source/WebCore/platform/audio/AudioBus.cpp:385
> +	   vadd(sourceC, 1, destination, 1, destination, 1, length());

This is basically exactly the same code as in speakersCopyFrom. Could you
refactor it into a separate method to share the code?