[webkit-reviews] review granted: [Bug 110652] add to HistoryItem a way to know if its underlying CachedPage has expired : [Attachment 189888] patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alice Liu <alice.liu at apple.com>'s
request for review:
Bug 110652: add to HistoryItem a way to know if its underlying CachedPage has
expired
https://bugs.webkit.org/show_bug.cgi?id=110652

Attachment 189888: patch
https://bugs.webkit.org/attachment.cgi?id=189888&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189888&action=review


r+ with that change

> Source/WebCore/history/CachedPage.cpp:56
>      : m_timeStamp(currentTime())
> +    , m_expiration(m_timeStamp +
page->settings()->backForwardCacheExpirationInterval())
>      , m_cachedMainFrame(CachedFrame::create(page->mainFrame()))

Could this be m_expirationTime instead?

> Source/WebCore/history/CachedPage.cpp:122
> +bool CachedPage::hasExpired() const
> +{
> +    return currentTime() > m_expiration;
> +}

If it was, this code would read more naturally.