[webkit-reviews] review denied: [Bug 110846] [JSC] static methods with Callback should not have this pointer : [Attachment 190322] patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 110846: [JSC] static methods with Callback should not have this pointer
https://bugs.webkit.org/show_bug.cgi?id=110846

Attachment 190322: patch
https://bugs.webkit.org/attachment.cgi?id=190322&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190322&action=review


The change to CodeGeneratorJS.pm looks good.

> Source/WebCore/bindings/scripts/test/TestObj.idl:150
> +    void    staticMethodWithCallbackAndOptionalArg(in [Callback, Optional]
TestCallback callback);
> +    void    staticMethodWithCallbackArg(in [Callback] TestCallback
callback);

You need to add 'static' to these methods.