[webkit-reviews] review denied: [Bug 105979] getComputedStyle() should return zoom-adjusted offset values : [Attachment 189181] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 105979: getComputedStyle() should return zoom-adjusted offset values
https://bugs.webkit.org/show_bug.cgi?id=105979

Attachment 189181: Patch
https://bugs.webkit.org/attachment.cgi?id=189181&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189181&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:662
> +	   renderer->document()->updateLayoutIgnorePendingStylesheets();
> +	   LayoutUnit containingBlockSize = (propertyID == CSSPropertyLeft ||
propertyID == CSSPropertyRight) ?
> +	       toRenderBox(renderer)->containingBlockLogicalWidthForContent() :

> +	      
toRenderBox(renderer)->containingBlockLogicalHeightForContent(ExcludeMarginBord
erPadding);

This code sequence is incorrect. Calling updateLayout can result in the
renderer being destroyed, so it’s not safe to use renderer after that. The
renderer may no longer exist, or may not be a box.

Generally speaking, when we update layout, all renderers are invalid and must
be refetched. I believe that includes renderView.