[webkit-reviews] review denied: [Bug 109879] Plugin in iframe may not display : [Attachment 190209] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 26 09:06:13 PST 2013
Simon Fraser (smfr) <simon.fraser at apple.com> has denied John Bauman
<jbauman at chromium.org>'s request for review:
Bug 109879: Plugin in iframe may not display
https://bugs.webkit.org/show_bug.cgi?id=109879
Attachment 190209: Patch
https://bugs.webkit.org/attachment.cgi?id=190209&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190209&action=review
> Source/WebCore/plugins/PluginView.cpp:164
> +void PluginView::clipRectChanged()
> +{
> + updatePluginWidget();
> +}
Why doesn't this call the base class function?
> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:227
> + Widget::clipRectChanged();
Is this necessary? It would be nice to have a virtual function on Widget that
doesn't require remembering to call the base class.
> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1590
> + virtual void clipRectChanged()
> + {
> + // Changing the clip rect doesn't affect the view hierarchy, so the
plugin must be told about the change directly.
> + [(WebBaseNetscapePluginView *)platformWidget() updateAndSetWindow];
> + }
Ditto.
More information about the webkit-reviews
mailing list