[webkit-reviews] review canceled: [Bug 110866] Web Inspector: Refactor AuditsPanel with AuditController as newly introduced entity : [Attachment 190253] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Vivek Galatage
<vivekg at webkit.org>'s request for review:
Bug 110866: Web Inspector: Refactor AuditsPanel with AuditController as newly
introduced entity
https://bugs.webkit.org/show_bug.cgi?id=110866

Attachment 190253: Patch
https://bugs.webkit.org/attachment.cgi?id=190253&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190253&action=review


Barring the file patching for the new JS addition, looks good for a start.

> Source/WebCore/ChangeLog:16
> +	   * inspector/front-end/AuditController.js: Added.

You forgot to patch WebCore.vcproj and compile-front-end.py for the new file.

> Source/WebCore/inspector/front-end/AuditController.js:91
> +	   this._auditsPanel._auditFinishedCallback(mainResourceURL, results);

For the time being, you should remove the leading '_' from
"_auditFinishedCallback", since this denotes a file-private member. Hopefully,
this will get removed altogether soon.

> Source/WebCore/inspector/front-end/AuditLauncherView.js:160
> +	   this._auditController.initiateAudit(catIds, this._progressIndicator,
this._auditPresentStateElement.checked, onAuditStarted.bind(this),
this._setAuditRunning.bind(this, false));

These callbacks will go away once we migrate to the events.